fix(harness): align subagent task output timeout#1452
Open
luowanghaoyun wants to merge 1 commit into
Open
Conversation
Ensure HarnessAgent tool execution timeout exceeds task_output blocking waits and include tool identifiers in timeout errors.
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1451
Ensure HarnessAgent tool execution timeout exceeds task_output blocking waits and include tool identifiers in timeout errors.
AgentScope-Java Version
1.1.0-SNAPSHOT
Description
Background
When
HarnessAgentenables subagent orchestration,task_outputsupports blocking up to 10 minutes via itstimeoutparameter (max: 600000ms). However, the default tool execution configuration (ExecutionConfig.TOOL_DEFAULTS) applies a 5-minute timeout at the framework level.As a result, a long-running
task_output(block=true, timeout=600000)call can be interrupted by the tool executor before the tool's own wait limit is reached.Changes
TaskToolMAX_BLOCK_WAIT_MILLIS/MAX_BLOCK_WAIT(10 minutes) and reuse them intask_outputtimeout clamping.HarnessAgentTaskTool.MAX_BLOCK_WAIT + 1 minute(11 minutes) if the user config is unset or not greater than 10 minutes.ToolExecutorTool 'task_output' (id=...) execution timeout after PT5M.Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)